Daniel Erez has posted comments on this change. Change subject: core: fix stateless flow in RestoreAllSnapshots ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23789/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java: Line 248: restoreConfiguration(targetSnapshot); Line 249: break; Line 250: Line 251: case STATELESS: Line 252: imagesToRestore = getParameters().getImages(); > yep, i saw - what i'm asking is if the stateless case was broken without it Yes, that's the fix for the bug. It worked previously as the disks to restore have been taken from getImagesList(). Line 253: restoreConfiguration(targetSnapshot); Line 254: break; Line 255: Line 256: // Currently UI sends the "in preview" snapshot to restore when "Commit" is pressed. -- To view, visit http://gerrit.ovirt.org/23789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aeb6ac37b511e0cd39b290f9571d0a73c7a5717 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
