Alexander Wels has posted comments on this change. Change subject: webadmin: title overlaps header icon ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23771/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java: Line 85: widget.addStyleName(style.contentWidget()); Line 86: } Line 87: Line 88: void updateTitlePadding() { Line 89: Scheduler.get().scheduleDeferred(new ScheduledCommand() { > Any chance that this will beat the element getting attached? No as the default scheduled command behaviour is to be added at the end of the queue, and attaching to the dom is part of the setWidget(WidgetUiBinder.uiBinder.createAndBindUi(this)); sequence which triggers this method to be called. Line 90: @Override Line 91: public void execute() { Line 92: int logoWidth = logoPanel.getOffsetWidth(); Line 93: if (logoWidth > 0) { -- To view, visit http://gerrit.ovirt.org/23771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I398b5daf8c02734a7b0e9e9777494100ee808d12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
