Liron Ar has posted comments on this change. Change subject: core: Block live storage migration to domain of a different type ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23759/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java: Line 281: && isTemplateInDestStorageDomain(parameters.getImageId(), parameters.getStorageDomainId()) Line 282: && validateSourceStorageDomain(sourceDomain) Line 283: && validateDestStorage(destDomain) Line 284: && validateDestStorageAndSourceStorageOfSameTypes(destDomain, sourceDomain)); Line 285: > Too much overhead unfortunately, the validators check existence and status I think that it should be done, it could be very frustrating to a user to activate a domain just to find out that it can't be done. Anyway, i'm not blocking this change over it..but i do think that improving the user experience at this low price is required and then we could use it on other flows as well - that's a minor change in the validator. Anyway, it's fine by me if you don't want to change this in this patch..please respond to Itamar's comment. Line 286: if (!getReturnValue().getCanDoAction()) { Line 287: return false; Line 288: } Line 289: } -- To view, visit http://gerrit.ovirt.org/23759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Cheryn Tan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
