Maor Lipchuk has posted comments on this change.
Change subject: core: fix null quota at import (#820131)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 352: ((DiskImage) dit).setQuotaId(quotaIdToConsume);
The disk is still using the VM quota, which is wrong.
The behaviour should be that the if the quota is disabled in the DC then set
the disk with the default quota of the DC.
other wise If the DC quota is not disabled, then apply the disk with the quota
the user sent.
As an example you can see how addVmCommand use validate quota.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java
Line 61: log.debugFormat("Quota id which will be consume from is
the default DC quota");
With this code change, each operation (addVm add template and many more) will
not be relevant any more since it will always use the default quota, instead of
the quota that has been sent by the user.
--
To view, visit http://gerrit.ovirt.org/4336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8108f6b9023a5e70ffa16a7d10a244b165a44050
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
