Juan Hernandez has posted comments on this change. Change subject: core: Set artifact version to 3.3.4-SNAPSHOT ......................................................................
Patch Set 1: Changing the version number in the POMs doesn't change any .jar file name, as we don't include the version number in the installed .jar files. The only place were the .jar file name will change is in the maven repositories where artifacts are installed. Not changing the name there when making a release is a mistake. Currently nobody cares about this because we don't upload the generated artifacts to public repositories. We will soon require correct artifact versions in order to generate the Python and Java SDKs from metadata generated during build time instead of runtime. The identifier to locate this metadata will be the artifact version number, even if it is stored only in the local maven repository. So please, fix this. -- To view, visit http://gerrit.ovirt.org/23764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c31641ed79cb5aeb414bccf49bc05586309b259 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
