Kiril Nesenko has posted comments on this change.

Change subject: Unify ovirt-release-fedora and ovirt-release-el6
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.ovirt.org/#/c/23661/3/Makefile.am
File Makefile.am:

Line 32:        $(srcdir)/ovirt-epel.repo \
Line 33:        $(srcdir)/ovirt.repo.in \
Line 34:        $(NULL)
Line 35: 
Line 36: rpms: dist
lets make it just : make rpm ?
Line 37:        rpmbuild $(RPM_FLAGS) -ta $(distdir).tar.gz
Line 38: 
Line 39: srpms: dist
Line 40:        rpmbuild $(RPM_FLAGS) -ts $(distdir).tar.gz


Line 35: 
Line 36: rpms: dist
Line 37:        rpmbuild $(RPM_FLAGS) -ta $(distdir).tar.gz
Line 38: 
Line 39: srpms: dist
and srpm ?
Line 40:        rpmbuild $(RPM_FLAGS) -ts $(distdir).tar.gz
Line 41: 


http://gerrit.ovirt.org/#/c/23661/3/ovirt-release.spec.in
File ovirt-release.spec.in:

Line 52: make %{?_smp_mflags}
Line 53: 
Line 54: 
Line 55: %install
Line 56: rm -rf $RPM_BUILD_ROOT
"%{buildroot}"
Line 57: %make_install
Line 58: #Allow ghost files
Line 59: install -d 755 "%{buildroot}%{_sysconfdir}"/yum.repos.d
Line 60: touch "%{buildroot}%{_sysconfdir}"/yum.repos.d/ovirt.repo


-- 
To view, visit http://gerrit.ovirt.org/23661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b1c775e7afe36ef146fcfc2b7fed37f054a0c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dave Neary <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to