Michael Pasternak has posted comments on this change.
Change subject: rest: Add shareable and allow snapshot properties
......................................................................
Patch Set 4: (2 inline comments)
please add unit test for this props
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
Line 60: if (disk.isShareable()) {
1. potential NPE, you should check disk.isSetShareable()
2. Shareable is reference type, so assignment should happen either way
i.e disk.isShareable() not needed in if condition
Line 63: if (disk.isAllowSnapshot()) {
same
--
To view, visit http://gerrit.ovirt.org/4313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I523dcdf3f98bd81c6ca5edc07fa81bf1caf7959e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
