Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: clone VM ......................................................................
Patch Set 2: Code-Review+2 (4 comments) http://gerrit.ovirt.org/#/c/23806/2//COMMIT_MSG Commit Message: Line 10: - Adds a new button to the UP/WA Vm lists Line 11: - Adds a new dialog which contains: Line 12: - clone name Line 13: - include memory (enabled only for up or staring vms) Line 14: - warnings (for not snapshottable disks) are shareable disks being attached to the cloned VM or just filtered out? Line 15: - calls the CloneVmCommand Line 16: Line 17: Change-Id: I6ae2bca7ce33412da3881ccadc9bb1543e32ace2 Line 18: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058832 http://gerrit.ovirt.org/#/c/23806/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.ui.xml: Line 11: Line 12: <g:FlowPanel> Line 13: <ge:StringEntityModelTextBoxEditor ui:field="cloneNameEditor" /> Line 14: <ge:EntityModelCheckBoxEditor ui:field="includeMemoryEditor" /> Line 15: <g:FlowPanel ui:field="warningsPanel" addStyleNames="{style.messagePanel}" /> nit: consider correlate the names Line 16: </g:FlowPanel> Line 17: http://gerrit.ovirt.org/#/c/23806/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java: Line 519: onSave(); Line 520: } Line 521: else if (command.getName().equals("closeVncInfo")) { //$NON-NLS-1$ Line 522: setWindow(null); Line 523: } else if (StringHelper.stringsEqual(command.getName(), "OnClone")) { //$NON-NLS-1$ formatter Line 524: onClone(); Line 525: } Line 526: } Line 527: http://gerrit.ovirt.org/#/c/23806/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmModel.java: Line 65: @Override Line 66: public void onSuccess(Object target, Object returnValue) { Line 67: CloneVmModel cloneVmModel = (CloneVmModel) target; Line 68: ArrayList<Disk> disks = (ArrayList<Disk>) returnValue; Line 69: diskImages = What about shareable disks (image/directlun), shouldn't we attach them? Line 70: Linq.toList(Linq.<DiskImage>filterDisksByStorageType(disks, Disk.DiskStorageType.IMAGE)); Line 71: Line 72: VmModelHelper.sendWarningForNonExportableDisks(cloneVmModel, disks, VmModelHelper.WarningType.VM_CLONE); Line 73: stopProgress(); -- To view, visit http://gerrit.ovirt.org/23806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae2bca7ce33412da3881ccadc9bb1543e32ace2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
