Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: move build config to proper place as well
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.ovirt.org/#/c/23617/11/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py:

Line 511
Line 512
Line 513
Line 514
Line 515
do above in else


Line 515:             shutil.copytree(
Line 516:                 
oreportscons.FileLocations.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR,
Line 517:                 
oreportscons.FileLocations.OVIRT_ENGINE_REPORTS_JASPER_WAR,
Line 518:                 symlinks=True,
Line 519:             )
do not copy tree as not required as far as I understand only copy quartz file 
out of legacy into:

 self._quartzprops = os.path.join(self._temproot, 'quartzprops')

move this statement above
Line 520: 
Line 521:             self.logger.info(_('Regenerating build conf files'))
Line 522: 
Line 523:             rc, stdout, stderr = self.execute(


-- 
To view, visit http://gerrit.ovirt.org/23617
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to