Ori Liel has posted comments on this change.

Change subject: restapi: Empty String Validation (#1005296)
......................................................................


Patch Set 1:

I consulted with Michael if such a thing exists in the API. He said maybe in 
one or two place. This is a very rare use case. In 99.9% of the cases, if we 
want to validate that user passed a value for some textual field, that means 
that we actually expect a value there, not "", or things wont work. 

For the one or two cases throughout the API that allow empty string - there we 
can validate manually and not use validateParameters() method. From what I 
could tell right now this method is not used for them anyway, and all junits 
and regression tests pass, so....

-- 
To view, visit http://gerrit.ovirt.org/23999
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0556725ad2ddc607d587c079bad451e4b74972d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to