Allon Mureinik has uploaded a new change for review. Change subject: core: Use correct storage validation for MoveVM ......................................................................
core: Use correct storage validation for MoveVM Fix MoveVMCommand to use the new (correct) StorageDomainValidator.hasSpaceForClonedDisks(Iterable<DiskImage>) to validate the destination domain has enough space. Change-Id: I7f455ff16d11622be4e28ea84180551237a80db1 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/24027/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java index 0b852fd..dfd95430 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java @@ -110,7 +110,9 @@ } private boolean destinationHasSpace(Collection<DiskImage> diskImages) { - return validate(new StorageDomainValidator(getStorageDomain()).isDomainHasSpaceForRequest((long) ImagesHandler.sumImagesTotalSizeWithSnapshotSize(diskImages))); + StorageDomainValidator sdv = new StorageDomainValidator(getStorageDomain()); + return validate(sdv.isDomainWithinThresholds()) && + validate(sdv.hasSpaceForClonedDisks(diskImages)); } protected boolean checkTemplateInStorageDomain(List<DiskImage> diskImages) { -- To view, visit http://gerrit.ovirt.org/24027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7f455ff16d11622be4e28ea84180551237a80db1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
