Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added upgrade path from legacy setup ......................................................................
Patch Set 17: (6 comments) http://gerrit.ovirt.org/#/c/23617/17/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py: Line 118: 'buildomatic', Line 119: 'build_conf', Line 120: 'default', Line 121: 'master.properties', Line 122: ) constants Line 123: ): Line 124: self.environment[oreportscons.CoreEnv.ENABLE] = True Line 125: p = os.path.join( Line 126: self.environment[ Line 139: config = configparser.ConfigParser() Line 140: config.optionxform = str Line 141: with open( Line 142: p Line 143: ) as f: no need for line wrap. Line 144: config.readfp( Line 145: io.StringIO( Line 146: '[default]' + Line 147: f.read().decode('utf-8') http://gerrit.ovirt.org/#/c/23617/17/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 610 Line 611 Line 612 Line 613 Line 614 see this... Line 505: ), Line 506: ) Line 507: def _export(self): Line 508: Line 509: config = None no need, both locations. Line 510: config = self._jasperConfiguration() Line 511: Line 512: self.logger.info(_('Exporting data out of Jasper')) Line 513: Line 561: raise RuntimeError( Line 562: _('Could not regenerate build configuration') Line 563: ) Line 564: finally: Line 565: os.umask(myumask) add chmod 0700 to build conf Line 566: else: Line 567: raise RuntimeError( Line 568: _('Could not detect Jasper war folder') Line 569: Line 896: oreportscons.ConfigEnv.JASPER_HOME Line 897: ], Line 898: 'buildomatic', Line 899: 'build_conf', Line 900: ), constant Line 901: ): Line 902: if os.path.exists(d): Line 903: self.logger.debug(_('Removing folder: %s'), d) Line 904: shutil.rmtree(d) -- To view, visit http://gerrit.ovirt.org/23617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
