Daniel Erez has uploaded a new change for review. Change subject: webadmin: new vm - fix host selection on cluster change ......................................................................
webadmin: new vm - fix host selection on cluster change When changing dc/cluster in VM dialog, the selected host was empty as it dependeds on the ' oldDefaultHost' Fixed by ensuring that an item from the hosts list is selected. Change-Id: Icd80711a9c1557743946445196c3c0015d94fc26 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/24077/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java index c901cf9..969332d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java @@ -511,8 +511,16 @@ else { model.getDefaultHost().setItems(hosts); - model.getDefaultHost().setSelectedItem(oldDefaultHost != null ? Linq.firstOrDefault(hosts, - new Linq.HostPredicate(oldDefaultHost.getId())) : Linq.firstOrDefault(hosts)); + + if (oldDefaultHost != null) { + // Trying to get host object from hosts list + oldDefaultHost = Linq.firstOrDefault(hosts, new Linq.HostPredicate(oldDefaultHost.getId())); + } + + // If found 'oldDefaultHost' in existing list, select it; + // otherwise, select first in hosts list. + model.getDefaultHost().setSelectedItem(oldDefaultHost != null ? + oldDefaultHost : Linq.firstOrDefault(hosts)); } changeDefualtHost(); -- To view, visit http://gerrit.ovirt.org/24077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd80711a9c1557743946445196c3c0015d94fc26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
