Tal Nisan has posted comments on this change.

Change subject: core: allow attaching iso and export SDs to local DC
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24115/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java:

Line 157:         return returnValue;
Line 158:     }
Line 159: 
Line 160:     protected boolean isStorageDomainTypeCorrect(StorageDomain 
storageDomain) {
Line 161:         if (storageDomain.getStorageDomainType() != 
StorageDomainType.ISO
Please use isStorageDomainOfTypeIsoOrExport
Line 162:                 && storageDomain.getStorageDomainType() != 
StorageDomainType.ImportExport
Line 163:                 && storageDomain.isLocal() != 
getStoragePool().isLocal()) {
Line 164:             
addCanDoActionMessage(VdcBllMessages.ERROR_CANNOT_ATTACH_STORAGE_DOMAIN_STORAGE_TYPE_NOT_MATCH);
Line 165:             return false;


-- 
To view, visit http://gerrit.ovirt.org/24115
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba6619b3b2858ab60ffb4df4824ae51467a2ecd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to