Itamar Heim has posted comments on this change. Change subject: core: adjustments needed to support instance types ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/23828/12//COMMIT_MSG Commit Message: Line 9: Three things had to be changed: Line 10: - permissions: the instance types need a bit different permissions than the Line 11: template. Since they are not cluster dependent they don't need that Line 12: permissions. But at the same time, they need a system level permission to Line 13: create template. so as a cluster admin i can't create an instance type in scope of my cluster? (or do for now we only have system wide instance types?) Line 14: - devices: when creating an instance type, the permissions are not copied from Line 15: a VM (since there is no base VM). Instead a blank template's devices are used Line 16: - Since the instace types are stored to vm_static but they are not cluster Line 17: dependent, the vds_groups_vm_static had to be removed. Since from now the -- To view, visit http://gerrit.ovirt.org/23828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaebd849061efa1637f9fa21d8584212ba0e51f2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
