Sahina Bose has uploaded a new change for review. Change subject: engine: Fix updation of gluster task info ......................................................................
engine: Fix updation of gluster task info Whenever status of remove-brick or rebalance is queried, the corresponding step information is updated. Fixed to do this only for in progress jobs Change-Id: I8e431da7797911372f8b6e474a4ab74c6626366d Bug-Url: https://bugzilla.redhat.com/1061725 Signed-off-by: Sahina Bose <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/24151/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java index 6bad44b..47e2936 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java @@ -116,11 +116,12 @@ asyncTask.setTaskParameters(taskParameters); List<Step> stepsList = getStepDao().getStepsByExternalId(asyncTask.getTaskId()); - - asyncTask.setStatus(status.getStatusSummary().getStatus()); - asyncTask.setMessage(GlusterTaskUtils.getInstance().getSummaryMessage(status.getStatusSummary())); - getGlusterTaskUtils().updateSteps(getClusterDao().get(clusterId), asyncTask, stepsList); - + if (stepsList != null && !stepsList.isEmpty() && stepsList.get(0).getEndTime() != null) { + // if job has already ended, do not update status. + asyncTask.setStatus(status.getStatusSummary().getStatus()); + asyncTask.setMessage(GlusterTaskUtils.getInstance().getSummaryMessage(status.getStatusSummary())); + getGlusterTaskUtils().updateSteps(getClusterDao().get(clusterId), asyncTask, stepsList); + } // release the volume lock if the task is completed if (getGlusterTaskUtils().hasTaskCompleted(asyncTask)) { getGlusterTaskUtils().releaseLock(volume.getId()); -- To view, visit http://gerrit.ovirt.org/24151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e431da7797911372f8b6e474a4ab74c6626366d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
