Liron Ar has uploaded a new change for review.

Change subject: detach
......................................................................

detach

Change-Id: I4db94dc9c06026d2ba713417822075fa2d08c79e
Signed-off-by: Liron Aravot <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/24181/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
index 62eb7a4..c9cfe79 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
@@ -58,6 +58,8 @@
             DiskImage diskImage = (DiskImage)ovfDisk;
             RemoveImageParameters removeImageParameters = new 
RemoveImageParameters();
             removeImageParameters.setDiskImage(diskImage);
+            removeImageParameters.setParentParameters(removeImageParameters);
+            removeImageParameters.setParentCommand(VdcActionType.RemoveImage);
             VdcReturnValueBase vdcReturnValue = 
Backend.getInstance().runInternalAction(VdcActionType.RemoveImage, 
removeImageParameters);
             if (vdcReturnValue.getSucceeded()) {
                 
startPollingAsyncTasks(vdcReturnValue.getInternalVdsmTaskIdList());
@@ -65,7 +67,6 @@
                 log.info("Failed to remove the domain disk ovf store, please 
remove it and try again");
                 addCustomValue("DiskAlias", ovfDisk.getDiskAlias());
                 AuditLogDirector.log(this, 
AuditLogType.DELETE_OVF_STORE_FOR_STORAGE_DOMAIN_FAILED);
-                setSucceeded(false);
                 return;
             }
         }


-- 
To view, visit http://gerrit.ovirt.org/24181
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4db94dc9c06026d2ba713417822075fa2d08c79e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to