Juan Hernandez has posted comments on this change.
Change subject: gluster:Datatype change for bytesRead & bytesWritten from int
to long.
......................................................................
Patch Set 1:
>From a modelling point of view, it isn't a problem. Currently we have this:
<gluster_clients>
<gluster_client>
<host_name>127.0.0.1</host_name>
<client_port>1013</client_port>
<bytes_read>776</bytes_read>
<bytes_written>676<bytes_written>
</gluster_client>
...
</gluster_clients>
What I'm suggesting is to use the statistics elements that we already use in
other places:
<gluster_clients>
<gluster_client>
<host_name>127.0.0.1</host_name>
<client_port>1013</client_port>
<statistics>
<statistic>
<name>bytes.read</name>
<description>Bytes read</description>
<values type="INTEGER">
<value>
<datum>776</datum>
</value>
</values>
<type>GAUGE</type>
<unit>BYTES</unit>
</statistic>
<statistic>
<name>bytes.written</name>
<description>Bytes written</description>
<values type="INTEGER">
<value>
<datum>676</datum>
</value>
</values>
<type>GAUGE</type>
<unit>BYTES</unit>
</statistic>
</statitstics>
</gluster_client>
...
</gluster_clients>
I know that this is verbose, and that the implementation is much more
complicated, but it brings consistence with all the rest of the statistical
information that we provide in the RESTAPI.
You may consider it as a future enhancement.
--
To view, visit http://gerrit.ovirt.org/23932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dd8f372059a4d0616bef34325e23d88a959bcba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Darshan N <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
