Moti Asayag has posted comments on this change. Change subject: engine: Initialize MAC pool partially ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24247/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java: Line 25: import org.ovirt.engine.core.utils.log.LogFactory; Line 26: Line 27: public class MacPoolManager { Line 28: Line 29: private static final Integer MAX_MACS_IN_POOL = Config.<Integer> getValue(ConfigValues.MaxMacsCountInPool); IIRC a preparation was made for auto-refreshing configuration values, therefore i'd recommend on not caching this value. Line 30: private static final String INIT_ERROR_MSG = "{0}: Error in initializing MAC Addresses pool manager."; Line 31: private static final MacPoolManager INSTANCE = new MacPoolManager(); Line 32: Line 33: private static Log log = LogFactory.getLog(MacPoolManager.class); -- To view, visit http://gerrit.ovirt.org/24247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0547509eb81a51599e2342503c9f108df1fa47c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
