Moti Asayag has posted comments on this change. Change subject: core: HA Vm reservation check failure event log is not well resolved ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24246/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 783: AuditLogableBase logable = new AuditLogableBase(); Line 784: logable.setVdsGroupId(cluster.getId()); Line 785: logable.addCustomValue("ClusterName", cluster.getName()); Line 786: Line 787: // create a string of host names VDS entity implements the Nameable interface, therefore the following should work instead of the new added code: String failedHostsStr = StringUtils.join(Entities.objectNames(returnedFailedHosts), ", "); Line 788: final StringBuilder buf = new StringBuilder(returnedFailedHosts.size() * 16); Line 789: for (int i = 0; i < returnedFailedHosts.size(); i++) { Line 790: if (i > 0) { Line 791: buf.append(SEPARATOR); -- To view, visit http://gerrit.ovirt.org/24246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I245f8eea3a955bcd8e75c574c572cf2608452d68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
