Liron Ar has posted comments on this change. Change subject: core, restapi: provide capabillity to get vm ovf config ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24287/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java: Line 54: vm.getDiskMap().put(entry.getKey(), list.get(list.size() - 1)); Line 55: } Line 56: return vm; Line 57: } Line 58: note : this code is 99% copy pasted code from OvfDataUpdater. all that code is being deleted from OvfDataUpdater in this patch to reduce the ongoing noise as we need this capability asap: http://gerrit.ovirt.org/#/c/24288/ Line 59: public String generateOvfConfigurationForVm(VM vm) { Line 60: if (VMStatus.ImageLocked != vm.getStatus()) { Line 61: VmHandler.updateDisksFromDb(vm); Line 62: DiskImagesValidator validator = new DiskImagesValidator(vm.getDiskList()); -- To view, visit http://gerrit.ovirt.org/24287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cbcd666519ffd138fd3efd4e130495529eaec0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
