Maor Lipchuk has posted comments on this change. Change subject: core: QuotaManager handle null quota ......................................................................
Patch Set 2: I'm not sure this would be the best solution, its fixing a but with another bug. The quota id of the VM should be valid, if its not, we need to find out why it is not set. Few question regarding this solution: 1. What if the quotaId is null, then we will fail the operation, this approach will only be permissive for wrong Guid (probably an empty Guid). 2. If this is the approach then it should be also for storage quota, not only vdsGroup 3. Please separate format path from logic patch, there are few changes there, which is hared to distinguish which do what -- To view, visit http://gerrit.ovirt.org/4337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e28e635c6d5e6a15162abbe38ba0c854c59ab5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
