Liron Ar has posted comments on this change. Change subject: core: Support detach Storage Domain with disks. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24286/1/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 999: END; $procedure$ Line 1000: LANGUAGE plpgsql; Line 1001: Line 1002: Line 1003: Create or replace FUNCTION getAllVMsWithDisksOnOtherStorageDomain(v_storage_domain_id UUID) RETURNS SETOF GetNamesOfVmStatic_rs > 1. if you only consider disks that are part of the ovf, shareable disks sho 1. regards 1 - "snapshot disks" attached to the vm should be excluded as well. Anyway, i don't see the ovf persisted disks as relevant of all, the purpose IMO is to tell the user "you are about the remove a vm which has disks that aren't on the domain, so after import this vm won't be the same anymore" if the user has attached lun/shareable/snapshot disk and the domain is detached, the vm won't be start using the same data. Line 1004: AS $procedure$ Line 1005: BEGIN Line 1006: RETURN QUERY SELECT DISTINCT vm_static.vm_name Line 1007: FROM vm_static -- To view, visit http://gerrit.ovirt.org/24286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
