Martin Sivák has posted comments on this change. Change subject: engine: Numa feature ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/23702/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaType.java: Line 2: Line 3: import java.util.HashMap; Line 4: import java.util.Map; Line 5: Line 6: public enum NumaType { I think this should be part of a separate patch. I do not see it being used anywhere except the Commons.xml file. Line 7: None(0), Line 8: Auto(1), Line 9: Manual(2); Line 10: http://gerrit.ovirt.org/#/c/23702/5/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml: Line 55: <include name="common/businessentities/OpenStackImageProviderProperties.java" /> Line 56: <include name="common/businessentities/VmBalloonInfo.java" /> Line 57: <include name="common/businessentities/ArchitectureType.java" /> Line 58: <include name="common/businessentities/IscsiBond.java" /> Line 59: <include name="common/businessentities/NumaType.java" /> The same thing about a separate patch applies here. Line 60: Line 61: <!-- Network business entities --> Line 62: <include name="common/businessentities/network/VdsNetworkInterface.java" /> Line 63: <include name="common/businessentities/network/NetworkInterface.java" /> -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
