Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. ......................................................................
Patch Set 6: (2 comments) Last two comments! http://gerrit.ovirt.org/#/c/24018/6/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java: Line 30: ")" + Line 31: "\\)" + Line 32: ")?" + Line 33: "\\s*" + Line 34: "" this should be at same nest level of the \\s* above. Line 35: ); Line 36: private static final Logger log = Logger.getLogger(FirstMatchSimpleFilter.class); Line 37: private Map<String, Transport> transports = new HashMap<>(); Line 38: private List<FilterEntry> notify = new LinkedList<>(); Line 189: public FilterEntry(String eventName, boolean exclude, String transport, String name) { Line 190: this.eventName = eventName; Line 191: this.exclude = exclude; Line 192: this.recipient = new Recipient(transport, name); Line 193: } just a question... is there a rule in the styles not to: public FilterEntry(String messageName, boolean exclude, Recipient recipient) { this.messageName = messageName; this.exclude = exclude; this.recipient = recipient; } public FilterEntry(String messageName, boolean exclude, String transport, String name) { this(messageName, exclude, new Recipient(transport, name)); } Line 194: Line 195: public String getEventName() { Line 196: return eventName; Line 197: } -- To view, visit http://gerrit.ovirt.org/24018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
