Fabian Deutsch has posted comments on this change. Change subject: engine_page: display url/port only on availble ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24421/1/src/engine_page.py File src/engine_page.py: Line 54: mgmtIface = [nets['ovirtmgmt'].get('iface', Line 55: nets['ovirtmgmt']['bridge'])] Line 56: Line 57: Line 58: if cfg["server"] is None or cfg["port"] is None: This will not show the url if port or host are missing, but it is value to show the host when the port is missing, so we could do something else. E.g. parts = [unicode(p) for p in [cfg["server"], cfg["port"] if p] txt = "http://%s"; % ":".join(parts) or so ... That way we reuse all informations if there is any. Line 59: engine_data = None Line 60: else: Line 61: engine_data = "oVirt Engine http://%s:%s"; % (cfg["server"], Line 62: cfg["port"]) -- To view, visit http://gerrit.ovirt.org/24421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d64a3d0c3530432544afbf3fe8a8155a2698d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
