Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier: move mail specific validations into smtp transport ......................................................................
Patch Set 1: You may consider to: 1. convert validation to something else that apart of validate also stores the values within members by correct type. 2. Collapse JavaMailSender into Smtp no need for two classes that cross use each other. -- To view, visit http://gerrit.ovirt.org/24520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c956198a2bb41deff7259607feb83dfe1a7ad53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
