Sergey Gotliv has uploaded a new change for review.

Change subject: webadmin: Fix allocation policy representation when editing VM 
disk
......................................................................

webadmin: Fix allocation policy representation when editing VM disk

Edit Vm disk window always displayed disk allocation policy as
preallocated even if its correct allocation policy is thin provisioning.

Change-Id: Ifae8052b4e37a7ad7f39eb38081268a7b6bd1a43
Signed-off-by: Sergey Gotliv <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/24532/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
index c8730c8..781df7c 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
@@ -527,7 +527,7 @@
         setVolumeFormat(AsyncDataProvider.getDiskVolumeFormat(volumeType, 
storageType));
     }
 
-    private void updateVolumeType(StorageType storageType) {
+    private void setDefaultVolumeType(StorageType storageType) {
         getVolumeType().setSelectedItem(storageType.isBlockDomain() ? 
VolumeType.Preallocated : VolumeType.Sparse);
         volumeType_SelectedItemChanged();
     }
@@ -738,8 +738,8 @@
 
     private void storageDomain_SelectedItemChanged() {
         StorageDomain selectedStorage = (StorageDomain) 
getStorageDomain().getSelectedItem();
-        if (selectedStorage != null) {
-            updateVolumeType(selectedStorage.getStorageType());
+        if (selectedStorage != null && getIsNew()) {
+            setDefaultVolumeType(selectedStorage.getStorageType());
         }
         updateQuota((StoragePool) getDataCenter().getSelectedItem());
     }


-- 
To view, visit http://gerrit.ovirt.org/24532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifae8052b4e37a7ad7f39eb38081268a7b6bd1a43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to