Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: cleanup nfs exports usage ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24470/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py: Line 179: name=self._source, Line 180: content=content, Line 181: modifiedList=self.environment[ Line 182: otopicons.CoreEnv.MODIFIED_FILES Line 183: ], > >> engine-cleanup deletes the file in exports.d although it contained manua If we're moving the line without any chance for the user to understand we're doing that I don't think we should do. IIUC we don't ask the user to confirm ACLs if the domain exists and ACL are manually changed after setup. So IMHO either we should not touch them or ask the user permission to do the move and take ownership of the change. Or at least issue a big WARNING about that. Line 184: ) Line 185: ) Line 186: Line 187: if not self._generate: -- To view, visit http://gerrit.ovirt.org/24470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3df61b1b52aead5ddf457da14f26324dbc2a56c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
