Sergey Gotliv has uploaded a new change for review. Change subject: webadmin: Display empty list when failed to retrieve list of iso images ......................................................................
webadmin: Display empty list when failed to retrieve list of iso images Change-Id: Ie0d148e89c4574a7e286b07ce1ce94a88996493c Signed-off-by: Sergey Gotliv <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 10 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/24564/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java index bc1b886..046f7ca 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java @@ -112,19 +112,17 @@ stopProgress(); - if (returnValue == null || returnValue.getReturnValue() == null || !returnValue.getSucceeded()) { - return; + ArrayList<RepoImage> repoImageList = new ArrayList<RepoImage>(); + if (returnValue != null && returnValue.getReturnValue() != null && returnValue.getSucceeded()) { + repoImageList = returnValue.getReturnValue(); + + Collections.sort(repoImageList, new Comparator<RepoImage>() { + @Override + public int compare(RepoImage a, RepoImage b) { + return a.getRepoImageId().compareToIgnoreCase(b.getRepoImageId()); + } + }); } - - @SuppressWarnings("unchecked") - ArrayList<RepoImage> repoImageList = (ArrayList<RepoImage>) returnValue.getReturnValue(); - - Collections.sort(repoImageList, new Comparator<RepoImage>() { - @Override - public int compare(RepoImage a, RepoImage b) { - return a.getRepoImageId().compareToIgnoreCase(b.getRepoImageId()); - } - }); setItems(repoImageList); setIsEmpty(repoImageList.isEmpty()); -- To view, visit http://gerrit.ovirt.org/24564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0d148e89c4574a7e286b07ce1ce94a88996493c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
