Ravi Nori has posted comments on this change. Change subject: restapi: adding support for affinity groups ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24069/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupVmsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupVmsResource.java: Line 62: protected Response performRemove(String id) { Line 63: AffinityGroup affinityGroup = getEntity(); Line 64: Line 65: if (!affinityGroup.getEntityIds().remove(GuidUtils.asGuid(id))) { Line 66: throw new WebApplicationException(Response.Status.NOT_FOUND); In other parts of restapi we do the following. if (!affinityGroup.getEntityIds().remove(GuidUtils.asGuid(id))) { notFound(); return null; } Please look at AbstractBackendNetworksResource.performRemove Line 67: } Line 68: return performAction(VdcActionType.EditAffinityGroup, new AffinityGroupCRUDParameters(affinityGroup.getId(), Line 69: affinityGroup)); Line 70: } -- To view, visit http://gerrit.ovirt.org/24069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2daa18742eca73517ef739e70e972d74aad4244 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
