Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: engine_page: display url/port only on availble
......................................................................

engine_page: display url/port only on availble

Do not show URL and PORT on status page if we don't have
these data available.

Change-Id: If2d64a3d0c3530432544afbf3fe8a8155a2698d2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057453
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
---
M src/engine_page.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node-plugin-vdsm 
refs/changes/90/24590/1

diff --git a/src/engine_page.py b/src/engine_page.py
index 38b3cb5..554d52a 100644
--- a/src/engine_page.py
+++ b/src/engine_page.py
@@ -43,6 +43,7 @@
        FIXME: Autoinstall should write MANAGED_BY and MANAGED_IFNAMES
        into /etc/defaults/ovirt
     """
+    engine_data = None
     cfg = VDSM().retrieve()
     networks = netinfo.networks()
 
@@ -54,13 +55,13 @@
             else:
                 mgmtIface = [networks[net]['iface']]
 
+
+    if cfg["server"] is not None:
+        server_url = [unicode(info) for info in [cfg["server"], cfg["port"]] 
if info]
+        engine_data = "oVirt Engine http://%s"; % ":".join(server_url)
+
     mgmt = Management()
-    mgmt.update(
-        "oVirt Engine http://%s:%s"; % (cfg["server"],
-                                       cfg["port"]),
-        mgmtIface,
-        None
-    )
+    mgmt.update(engine_data, mgmtIface, None)
 
 
 class Plugin(plugins.NodePlugin):


-- 
To view, visit http://gerrit.ovirt.org/24590
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2d64a3d0c3530432544afbf3fe8a8155a2698d2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to