Maor Lipchuk has posted comments on this change.
Change subject: core: Add floating disk to fixtures.xml
......................................................................
Patch Set 8: (1 inline comment)
looks good, minor comments
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
Line 105: private static void
assertFullGetAllAttachableDisksByPoolId(List<Disk> disks) {
Why the method name has the word Full in it?
I would consider changing the comment to be a bit more abstract, since
attachable disks should be also shareable disks.
--
To view, visit http://gerrit.ovirt.org/4436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2b1e927feba707e7ca7f382ce270cedc0a2bb80
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
