mooli tayer has posted comments on this change.

Change subject: utils: LocalConfig: add getProperty with an optionalSuffix 
String.
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/23979/11/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java:

Line 275:      * @param key            the name of the property
Line 276:      * @param optionalSuffix the suffix of the property, not 
including an underscore.
Line 277:      * @param allowMissing   define the behaviour if both key and 
key_optionalSuffix are not associated with a value
Line 278:      * @return the value associated with key_optionalSuffix if it is 
defined or the one associated with key otherwise.
Line 279:      * @throws java.lang.IllegalStateException if both 
key_optionalSuffix and key are not associated with a value and
> Please notice that the exception is thrown is IllegalArgumentException, as 
Done
Line 280:      *      allowMissing is false.
Line 281:      */
Line 282:     public String getProperty(String key, String optionalSuffix, 
boolean allowMissing) {
Line 283:         String property = getProperty(key + "_" + optionalSuffix, 
true);


-- 
To view, visit http://gerrit.ovirt.org/23979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37b6aa5ce44600fc647915b9f71632c98bbbae3
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to