Maor Lipchuk has posted comments on this change. Change subject: core: Filter GetAllAttachableDisksByPoolId ......................................................................
Patch Set 8: (1 inline comment) Looks good, minor comments .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java Line 110: dao.getAllAttachableDisksByPoolId(null, PRIVILEGED_USER_ID, false); Maybe use the test with UNPRIVILEGED_USER_ID will make it more effective. -- To view, visit http://gerrit.ovirt.org/4438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04f319a036952567f1e7f9a2761ec98753052bae Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
