Hello mooli tayer,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/24702

to review the following change.

Change subject: tools: notifier: reorder ovirt-engine-notifirt.conf.in 
according to sections.
......................................................................

tools: notifier: reorder ovirt-engine-notifirt.conf.in according to sections.

Change-Id: Iff27e5db7e5f5dc5febaf732c71c441c7b122e26
Signed-off-by: Mooli Tayer <[email protected]>
---
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
1 file changed, 24 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/24702/1

diff --git 
a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 
b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
index a0a1b21..202054d 100644
--- a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
+++ b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
@@ -50,6 +50,30 @@
 # Interval (in seconds) between iterations of dispatching messages to 
subscribers. Default is 120 seconds.
 INTERVAL_IN_SECONDS=120
 
+# Amount of days to keep dispatched events on history table. If 0, events 
remain on history table for ever.
+DAYS_TO_KEEP_HISTORY=0
+
+# Send a notification email after first failure to fetch notifications,
+# and then once every failedQueriesNotificationThreshold times.
+# 0 or 1 means notify on each failure.
+FAILED_QUERIES_NOTIFICATION_THRESHOLD=30
+
+# Comma separated list of email recipients to be informed in case
+# the notification service cannot connect to the DB. can be empty.
+# Deprecated, use FILTER with DATABASE_UNREACHABLE instead.
+FAILED_QUERIES_NOTIFICATION_RECIPIENTS=
+
+# This parameter specifies how many days of old events are processed and sent
+# when the notifier starts. If set to 2, for example, the notifier will
+# process and send the events of the last two days, older events will just
+# be marked as processed and won't be sent. The default is 0, so no old
+# messages will be sent at all during startup.
+DAYS_TO_SEND_ON_STARTUP=0
+
+#---------------------#
+# EMAIL Notifications #
+#---------------------#
+
 # The SMTP mail server address. Required.
 MAIL_SERVER=
 
@@ -75,25 +99,6 @@
 
 # Specifies 'reply-to' address on sent mail in RFC822 format.
 MAIL_REPLY_TO=
-
-# Amount of days to keep dispatched events on history table. If 0, events 
remain on history table.
-DAYS_TO_KEEP_HISTORY=0
-
-# This parameter specifies how many days of old events are processed and sent
-# when the notifier starts. If set to 2, for example, the notifier will
-# process and send the events of the last two days, older events will just
-# be marked as processed and won't be sent. The default is 0, so no old
-# messages will be sent at all during startup.
-DAYS_TO_SEND_ON_STARTUP=0
-
-# Send a notification email after first failure to fetch notifications,
-# and then once every failedQueriesNotificationThreshold times.
-# 0 or 1 means notify on each failure.
-FAILED_QUERIES_NOTIFICATION_THRESHOLD=30
-
-# Comma separated list of email recipients to be informed in case
-# the notification service cannot connect to the DB. can be empty.
-FAILED_QUERIES_NOTIFICATION_RECIPIENTS=
 
 #----------------------------------#
 # Engine Monitoring Configuration: #


-- 
To view, visit http://gerrit.ovirt.org/24702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff27e5db7e5f5dc5febaf732c71c441c7b122e26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to