Liron Ar has posted comments on this change. Change subject: engine: Introduce getConnectableStorageConnectionsByStorageType API ......................................................................
Patch Set 2: Code-Review+1 (2 comments) just add the bug-url to the commit message, +2 other than that http://gerrit.ovirt.org/#/c/24681/2//COMMIT_MSG Commit Message: Line 10: storage type. If storage type is not specified then this API returns Line 11: the same result as getAllConnectableStorageSeverConnection - all Line 12: connectable storage connections. Line 13: Line 14: Change-Id: I9cea901ff2707bb4caa52e8f8eff06d533d5ddb6 please add bug-url http://gerrit.ovirt.org/#/c/24681/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java: Line 61: * in the specified storage pool. If storage type is not specified then all connections of the same Line 62: * domains are returned. Line 63: * Line 64: * @param pool Line 65: * the storage pool suggestion - perhaps fix that comment in the master branch to be ("the storage pool id")..can be done for the original "getAllConnectable.." as well Line 66: * @param storageType Line 67: * the storage type Line 68: * Line 69: * @return the list of connections -- To view, visit http://gerrit.ovirt.org/24681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cea901ff2707bb4caa52e8f8eff06d533d5ddb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
