Liron Ar has posted comments on this change. Change subject: engine: Block setting a plugged disk as read only when the vm is running ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24797/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 257: return true; Line 258: } Line 259: Line 260: private boolean validateCanUpdateReadOnly() { Line 261: if (shouldUpdateReadOnly() && getVm().getStatus() != VMStatus.Down && vmDeviceForVm.getIsPlugged()) { what's the difference between update "readonly" /"boot" properties for the disk while the vm is running and the disk is plugged? for both of them it'll apply only through the next run.. we need a consistent behavior for all those edits (either an audit log that settings will take effect on the next vm run or block), if we do already block on boot, both should be blocked on the same place to avoid duplication. Line 262: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN); Line 263: } Line 264: return true; Line 265: } -- To view, visit http://gerrit.ovirt.org/24797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd16d91e02f26f2d6697b31233669a80a98534c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
