Liron Ar has posted comments on this change. Change subject: core: prevent illegal disk on custom preview active snapshot ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/24804/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java: Line 41: vm = getVmWithConfiguration(configuration, vmId); Line 42: Snapshot snapshot = getSnapshotDao().get(snapshotId); Line 43: if (snapshot != null && snapshot.getType() != Snapshot.SnapshotType.PREVIEW) { Line 44: // No need to mark disks of 'PREVIEW' snapshot as illegal Line 45: // as it represents previous 'Active VM' state. perhaps change the comment/commit message to explain the usecase better (missing record in images tab), i'd also add that this works while we rely on the fact that no operations on the disks may be done when we preview snapshot. Line 46: markImagesIllegalIfNotInDb(vm, snapshotId); Line 47: } Line 48: } else { Line 49: vm = getVmWithoutConfiguration(vmId, snapshotId); -- To view, visit http://gerrit.ovirt.org/24804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1561107e05de155f9483e1f8a00d2dba3a4ab342 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
