Alon Bar-Lev has posted comments on this change. Change subject: 8. [WIP] core: Introducing the extension interface ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24811/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Directory.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Directory.java: Line 10: /** Line 11: * A directory is an object that manages a collection of users and groups, usually stored in an external system like an Line 12: * LDAP database. Line 13: */ Line 14: public abstract class Directory implements Extension, Serializable { > Sorry, I still don't follow - what do you want to have at ExtensionImpl (be no I don't I just sharing my line of thoughts. as in future we will have no classes/abstract classes in the public interfaces we provide for extensions, it will be unwise to introduce it now. all I suggest is to modify the Extension interface to have simpler interface. Line 15: /** Line 16: * Line 17: */ Line 18: private static final long serialVersionUID = -8724317446083142917L; http://gerrit.ovirt.org/#/c/24811/1/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/Extension.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/Extension.java: Line 36: * Gets the configuration properties Line 37: * Line 38: * @return the configuration properties Line 39: */ Line 40: Properties getConfigurationProperties(); > Can you explain the usage of setProperty and getProperty here? well, the Properties of configuration is one property. we need more... such as name of extension, instance name of extension, author, license etc... I do not care if we go via map now... and the interface will be: // global context, mean to interact back with engine setContext(Map<Enum(future:UUID)><Object> context); // instance context setInstanceContext(Map<Enum(future:UUID)><Object> context); at instance context extension will find its configuration, and be able to set its name, license etc... what do you prefer? Line 41: -- To view, visit http://gerrit.ovirt.org/24811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f583d635c059972a2a536d3c49a58cfcf3234b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
