Itamar Heim has posted comments on this change.
Change subject: core: user level queries - filtered entities
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/dbscripts/upgrade/pre_upgrade/add_object_column_white_list_table.sql
Line 39: column_name not in
('pm_enabled','pm_user','pm_password','pm_port','pm_options'));
1. that's still a black list...
2. i wonder if we should not just start with host id and name, host_name and
only add other fields if requested to (or any other field which really make
sense)
--
To view, visit http://gerrit.ovirt.org/4469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If68b290aaacc0eea5d117ef64536cbf94d195cee
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
