Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing Extension manager ......................................................................
Patch Set 27: (1 comment) http://gerrit.ovirt.org/#/c/24365/27/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 212: try { Line 213: Extension extension = (Extension) lookupService( Line 214: Extension.class, Line 215: entry.getConfig().getProperty(CLASS), Line 216: loadModule(entry.getConfig().getProperty(MODULE)) loadModule should be done within the lookupService, the interface should be plain strings. Line 217: ).newInstance(); Line 218: extension.setContext(entry.context); Line 219: extension.init(); Line 220: entry.setExtension(extension); -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
