Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added patch handling for jrs pro ......................................................................
Patch Set 5: Code-Review+1 (1 comment) minor comment :) http://gerrit.ovirt.org/#/c/24910/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 839 Line 840 Line 841 Line 842 Line 843 in cases like this, we add () for each parameter... should be: for p in sorted( ( glob.glob( ) + glob.glob( ) ), key=..., ) -- To view, visit http://gerrit.ovirt.org/24910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cc6acf3646a3ba48733c08138b3eeaf57d8ccda Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
