Moti Asayag has posted comments on this change. Change subject: core: Java 7: Fix use of namespaces in StAX writer ......................................................................
Patch Set 2: Just to be on the safe side, code was tested on Java 6 as well, right? Personally I don't like the way the OVF is implemented at the moment, it looks a bit fragile and schema isn't enforced. I would have plan a head to replace current implementation with JAXB (which already included as part of the JDK) to create java objects from the ovf.xsd and use them to create an OVF object which will be serialized/deserialized from XML so we can also track versionning of the the OVF schema and enjoy the validation of it by the standard. However, it requires quite time. -- To view, visit http://gerrit.ovirt.org/4540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I144bab6daee284b424805c1c56d53d385f80b8ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
