Eli Mesika has posted comments on this change.
Change subject: core: USB devices
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
Line 13: SPICEVMC("spicevmc", "23"),
If all are 23 , how do you know what to create upon import ?
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
Line 200: protected void writeOtherDevices(VmBase vmBase, XmlTextWriter
write) {
What about OvfReader ?
If you export a VM with USB devices and import it to another system
Line 206: VmDeviceType.USB.getName().equals(device.getDevice())
||
Since as we talked this condition is duplicated in OvfVmReader , please
encapsulate in a method on the vm device utils class
--
To view, visit http://gerrit.ovirt.org/4371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id90e976cd85f584de37a08db1981287a6554b8b3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
