Itamar Heim has posted comments on this change. Change subject: Adapted stable branches checks and python ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/19600/6//COMMIT_MSG Commit Message: Line 8: Line 9: - Showing contact address when login error occurs Line 10: Line 11: Bug-Url hook: Line 12: - Skiping bugs out of the ovirt-related products I wouldn't skip. I'd print the product and target release as fyi Line 13: - If the patch is in the stable branch: Line 14: * -1 if no bug-url Line 15: * -1 if any target release incorrect Line 16: * -1 if any private bug Line 11: Bug-Url hook: Line 12: - Skiping bugs out of the ovirt-related products Line 13: - If the patch is in the stable branch: Line 14: * -1 if no bug-url Line 15: * -1 if any target release incorrect not clear what is "incorrect". 3.3.2 is valid for 3.4 stable branch, etc. same if the product isn't ovirt. so I'd just print the information as a warning if not ovirt or not matching version for maintainer to review Line 16: * -1 if any private bug Line 17: Line 18: set_POST hook: Line 19: - Warning message when not oVirt product -- To view, visit http://gerrit.ovirt.org/19600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I233f50c77fc2d419a5bc29b2ee5b3299c4bd6293 Gerrit-PatchSet: 6 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
