Alon Bar-Lev has posted comments on this change. Change subject: aaa: logs all enabled extensions ......................................................................
Patch Set 4: (2 comments) minor stupid and annoying comments... feel free to ignore me. http://gerrit.ovirt.org/#/c/24979/4/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 241: logEnabledExtensions(); Line 242: } Line 243: Line 244: private void logEnabledExtensions() { Line 245: log.info("Start of enabled extensions list: "); picky... no nede for ": " Line 246: for (ExtensionEntry entry: loadedEntries.values()) { Line 247: Map<ExtensionProperties, Object> context = entry.extension.getContext(); Line 248: if (entry.extension != null) { Line 249: log.info(String.format( Line 246: for (ExtensionEntry entry: loadedEntries.values()) { Line 247: Map<ExtensionProperties, Object> context = entry.extension.getContext(); Line 248: if (entry.extension != null) { Line 249: log.info(String.format( Line 250: "Name: %1$s Author %2$s Version %3$s Home: %4$s License: %5$s File: %6$s", please add single quotes per variable and comma Name: '$1$s', Version: '..' this will enable us to parse this line if so required. Line 251: emptyIfNull(context.get(ExtensionProperties.EXTENSION_NAME)), Line 252: emptyIfNull(context.get(ExtensionProperties.AUTHOR)), Line 253: emptyIfNull(context.get(ExtensionProperties.VERSION)), Line 254: emptyIfNull(context.get(ExtensionProperties.HOME)), -- To view, visit http://gerrit.ovirt.org/24979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99a7278cbcbbe54e2d3cb1dd96f6eda6100ae2ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
