Kobi Ianko has posted comments on this change. Change subject: add errors to the xmlrpc response ......................................................................
Patch Set 5: Code-Review+1 (1 comment) looks good, had 1 comment: I wouldn't have used lazy creation of objects in this case. http://gerrit.ovirt.org/#/c/24683/5/tests/java/src/main/java/org/ovirt/schedulerproxy/SchedulerResult.java File tests/java/src/main/java/org/ovirt/schedulerproxy/SchedulerResult.java: Line 5: import java.util.List; Line 6: import java.util.Map; Line 7: Line 8: public class SchedulerResult { Line 9: private Map<String, List<String>> pluginErrors = null; if you eagerly create the instance( private Map<String, List<String>> pluginErrors = new HashMap<>()), you will not need to null check in your method, and external call to getter will not need to null check either. Line 10: private int resultCode = 0; Line 11: private LinkedList<String> errorMessages = null; Line 12: Line 13: public Map<String, List<String>> getPluginErrors() { -- To view, visit http://gerrit.ovirt.org/24683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I765acfcc65555c046749ed51a21023418d870a35 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
