Eli Mesika has posted comments on this change. Change subject: userportal, webadmin: Prevent snapshot in ppc64 ......................................................................
Patch Set 9: (4 comments) http://gerrit.ovirt.org/#/c/21658/9/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java: Line 131: getTable().ensureColumnPresent(SnapshotsViewColumns.statusColumn, Line 132: constants.statusSnapshot(), true, "75px"); //$NON-NLS-1$ Line 133: Line 134: boolean memorySnapshotSupported = Line 135: getModel().getIsMemorySnapshotSupported(); Shouldn't this be isMemorySnapshotSupported to align to java notations Line 136: Line 137: getTable().ensureColumnPresent(SnapshotsViewColumns.memoryColumn, Line 138: constants.memorySnapshot(), memorySnapshotSupported, "55px"); //$NON-NLS-1$ Line 139: http://gerrit.ovirt.org/#/c/21658/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java: Line 195: onPropertyChanged(new PropertyChangedEventArgs("IsCloneVmSupported")); //$NON-NLS-1$ Line 196: } Line 197: } Line 198: Line 199: private boolean isMemorySnapshotSupported; This should be memorySnapshotSupported Line 200: Line 201: public boolean getIsMemorySnapshotSupported() Line 202: { Line 203: return isMemorySnapshotSupported; Line 197: } Line 198: Line 199: private boolean isMemorySnapshotSupported; Line 200: Line 201: public boolean getIsMemorySnapshotSupported() this should be isMemorySnapshotSupported Line 202: { Line 203: return isMemorySnapshotSupported; Line 204: } Line 205: Line 202: { Line 203: return isMemorySnapshotSupported; Line 204: } Line 205: Line 206: private void setIsMemorySnapshotSupported(boolean value) and this should be setMemorySnapshotSupported Line 207: { Line 208: if (isMemorySnapshotSupported != value) Line 209: { Line 210: isMemorySnapshotSupported = value; -- To view, visit http://gerrit.ovirt.org/21658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I148f0a9356086b31e66d4f5dd6eab6afc642cada Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: liron aravot <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
