anmolbabu has posted comments on this change. Change subject: webadmin : Volume Capacity UI - Part2 ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/23502/13/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java: Line 348: @DefaultStringValue("Total usage") Line 349: String tooltipTotalUsageLabel(); Line 350: Line 351: @DefaultStringValue("Could not fetch data \nClick the icon to refresh now") Line 352: String volumeCapacityNoData(); > is this being used? No I'll remove this.Its a duplicate. http://gerrit.ovirt.org/#/c/23502/13/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3549: @DefaultStringValue("Remove") Line 3550: String removeIscsiBond(); Line 3551: Line 3552: @DefaultStringValue("Could not fetch data \nClick the icon to refresh now") Line 3553: String volumeCapacityNoData(); > is this being used? Ya this one is used.However,The one in the other file isn't. Line 3554: Line 3555: @DefaultStringValue("iSCSI Multipathing") Line 3556: String dataCenterIscsiMultipathingSubTabLabel(); -- To view, visit http://gerrit.ovirt.org/23502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983daf32966527cdfa7773e07aa055a24519fbe2 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
